Conversation
SwiftLint found issuesWarnings
Errors
Generated by 🚫 Danger |
Zandor300
force-pushed
the
t3code/add-new-apple-device-support
branch
from
September 9, 2026 21:08
fbd9281 to
b01a580
Compare
Zandor300
force-pushed
the
t3code/add-new-apple-device-support
branch
from
September 10, 2026 08:13
b01a580 to
fe2c427
Compare
|
Hi, any news on this PR ? |
|
Grabbed the identifiers off the simulators, in case that helps with the placeholders:
( Since Display specs off Apple's page:
Ratios come out to 233:339 and 313:445. One gotcha if you read these from the simulator instead: it reports the inner screen as The two screens have different ppi though (460 vs 430), and there's only one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeviceKit currently lacks cases for iPhone 18 Pro, iPhone 18 Pro Max, iPhone Duo, Apple Watch Series 12, and Apple Watch Ultra 4. Add provisional entries for these models (including 42mm and 46mm Series 12 variants), using A20 Pro for the iPhones and S11 for the watches. Add
isFoldable, true only for iPhone Duo and its simulator, and regenerate the Swift source.Hardware identifiers remain unconfirmed: entries use
placeholder:<caseName>, so automatic detection requires replacing them with confirmed identifiers. Images are omitted, and the generator skips empty image documentation. Display metrics return unknown values (-1for diagonal/ratio andnilfor PPI). Pro and Watch capabilities and Series 12 sizes provisionally follow their predecessors; unconfirmed Duo capabilities use false/empty defaults. These assumptions are documented for verification before release.Validation:
swift testpassed on macOS.git diff --checkpassed.mapToDevice; the same rule fails on the unchanged baseline (140 branches versus 146 with the new entries).